[manuf] Fill entire attestation seeds flash info page with random bytes - #31042
Merged
Conversation
Fill the entire 2048-byte (512-word) attestation seeds flash info page (kFlashCtrlInfoPageAttestationKeySeeds) with random bytes generated by CSRNG in a single erase & write operation during manufacturing personalization. This provides entropy seeds for newly added ML-DSA keys as well as future keys without requiring individual per-seed code updates. Also increment the attestation keygen version to kAttestationKeyGenVersion1 (Gen 1) and update functests to verify the whole page. Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com> Change-Id: Iddcf050de962a297a1efc33a4c3c02056a6a6964
cfrantz
approved these changes
Aug 19, 2026
timothytrippel
approved these changes
Aug 24, 2026
| // Read the entire attestation key seed page to ensure the random words | ||
| // are non-zero and the version field matches kAttestationKeyGenVersion1. | ||
| enum { | ||
| kPageWords = FLASH_CTRL_PARAM_BYTES_PER_PAGE / sizeof(uint32_t), |
Contributor
There was a problem hiding this comment.
should we put this in a header file since it is used in multiple places?
timothytrippel
merged commit Aug 24, 2026
dd9bb17
into
lowRISC:earlgrey_1.0.0
100 of 105 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill the entire 2048-byte (512-word) attestation seeds flash info page (kFlashCtrlInfoPageAttestationKeySeeds) with random bytes generated by CSRNG in a single erase & write operation during manufacturing personalization. This provides entropy seeds for newly added ML-DSA keys as well as future keys without requiring individual per-seed code updates.
Also increment the attestation keygen version to
kAttestationKeyGenVersion1 (Gen 1) and update functests to verify the whole page.