Add opentitan_for_ip and fix docs on creating new top - #31025
Merged
Conversation
pamaury
approved these changes
Aug 17, 2026
gautschimi
approved these changes
Aug 17, 2026
gautschimi
left a comment
gautschimi
left a comment
Contributor
There was a problem hiding this comment.
I like the opentitan_for_ip! I could have used it a lot:)
gautschimi
reviewed
Aug 17, 2026
Fix typos and minor mistakes in the documentation, mostly in the "creating a new top" README document. Signed-off-by: Matteo Franchin <matteo.franchin@lowrisc.org>
Introduce opentitan_for_ip() to aid making compilation conditional on the IPs supported by the active top. Use the new construct in the test ROM BUILD file. Signed-off-by: Matteo Franchin <matteo.franchin@lowrisc.org>
engdoreis
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typos and minor mistakes in the documentation, mostly in the "creating a new top" README document.
Introduce
opentitan_for_ip()to aid making compilation conditional on the IPs supported by the active top.