[dv] Teach cip_base_scoreboard about allowed fetches - #29948
Open
rswarbrick wants to merge 1 commit into
Open
Conversation
rswarbrick
force-pushed
the
cip-base-scb-fetches
branch
2 times, most recently
from
May 7, 2026 20:17
11e6ef1 to
9a18287
Compare
rswarbrick
force-pushed
the
cip-base-scb-fetches
branch
from
August 12, 2026 22:15
9a18287 to
feae1a3
Compare
rswarbrick
force-pushed
the
cip-base-scb-fetches
branch
from
August 26, 2026 13:51
feae1a3 to
51a43b2
Compare
Commit ec5e1c4 taught virtual sequences not to target the debug ROM with fetches and expect TL errors. This commit teaches the analysis side of things to match. One change to the dv_base_reg_block code in this commit is that dv_base_reg_block::reg_allows_fetch is no longer local. In the previous commit, the virtual sequence worked by getting a list of registers that don't allow fetches, but that isn't very convenient for a scoreboard that has seen a fetch from a particular register. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
cip-base-scb-fetches
branch
from
August 26, 2026 13:54
51a43b2 to
e577547
Compare
Contributor
Author
|
The force-push rebases the work over a change that @andreaskurth landed a few days ago to do the sequence side of the work (thanks!) The new version just updates the scoreboard side of things to match. I'll update the PR message to match the commit message in a sec. |
rswarbrick
changed the title
rswarbrick
marked this pull request as ready for review
August 26, 2026 13:55
Contributor
Author
|
@andreaskurth: At the start of this week, I wrongly told you that this change depended on a bunch of vertical integration work that I was doing for |
KinzaQamar
reviewed
Aug 26, 2026
|
|
||
| // Does this address a register? If not, return false. | ||
| aligned_addr = block.get_word_aligned_addr(item.a_addr); | ||
| tgt_reg = block.get_default_map().get_reg_by_offset(aligned_addr, 1); |
Contributor
There was a problem hiding this comment.
You are setting the argument read of get_reg_by_offset() but is_tl_access_mapped_addr() doesn't. I s there a reason why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ec5e1c4 taught virtual sequences not to target the debug ROM with fetches and expect TL errors. This commit teaches the analysis side of things to match.
One change to the
dv_base_reg_blockcode in this commit is thatdv_base_reg_block::reg_allows_fetchis no longerlocal. In the previous commit, the virtual sequence worked by getting a list of registers that don't allow fetches, but that isn't very convenient for a scoreboard that has seen a fetch from a particular register.