Skip to content

Fix native asset packaging on Windows - #1324

Closed
GT-610 wants to merge 1 commit into
mainfrom
fix/windows-native-assets
Closed

Fix native asset packaging on Windows#1324
GT-610 wants to merge 1 commit into
mainfrom
fix/windows-native-assets

Conversation

@GT-610

@GT-610 GT-610 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • install native assets emitted by Dart build hooks beside the Windows executable
  • update flutter_pty to skip hook phases that do not build code assets

Problem

Windows builds generated the native asset manifest but did not copy its DLLs to the runner output directory. This caused RustLib.init() to fail to load sbm_ffi.dll before runApp, leaving a process running without an application window.

Testing

  • flutter run -d windows
  • verified the runner output contains sbm_ffi.dll, flutter_pty.dll, and sqlite3mc.dll
  • verified the app reaches normal startup without the native-library load error
  • flutter analyze lib/main.dart

Summary by CodeRabbit

  • Improvements
    • Windows installations now include required native assets automatically, improving runtime reliability.
    • Updated the embedded terminal component to incorporate the latest fixes and enhancements.

@GT-610 GT-610 closed this Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4758b453-a235-42d2-8408-98e139b96c92

📥 Commits

Reviewing files that changed from the base of the PR and between 204db34 and f78483d.

📒 Files selected for processing (2)
  • packages/flutter_pty
  • windows/CMakeLists.txt

📝 Walkthrough

Walkthrough

The packages/flutter_pty submodule reference moves to commit d8b917371f1fd1fb380f7b0f1148fa6c4cab67ca. Windows installation now copies native assets from native_assets/windows/ into the executable library directory as a Runtime component.

Suggested reviewers: lollipopkit

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-native-assets

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from lollipopkit August 21, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant