Add device flow authentication #18
Conversation
| if err := listener.Close(); err != nil { | ||
| log.Printf("failed to close listener: %v", err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
server.Shutdown() closes the listener, so no explicit close needed
carole-lavillonniere
force-pushed
the
carole/drg-450
branch
from
780adc5 to
e39bd29
Compare
| func getWebAppURL() string { | ||
| // allows overriding the URL for testing | ||
| if url := os.Getenv("LOCALSTACK_WEB_APP_URL"); url != "" { | ||
| return url |
There was a problem hiding this comment.
Not sure why I added this in the first place, but we never overwrite it at the moment, so I removed it.
There was a problem hiding this comment.
Theoretically we could use it to test against staging or locally started webapp.
I wonder though if we should maybe look into handling these envvars with the config package? I'll refactor it slightly later maybe
There was a problem hiding this comment.
👍 Makes sense. Put it back in.
I agree it would be good to have a central place to read env vars and not do it all over the codebase.
I used this in the past https://github.com/caarlos0/env
| assert.True(t, inspect.State.Running, "container should be running") | ||
| } | ||
|
|
||
| func TestStartCommandTriggersLoginWithoutToken(t *testing.T) { |
There was a problem hiding this comment.
This test was just moved to test/integration/login_browser_flow_test.go
carole-lavillonniere
force-pushed
the
carole/drg-450
branch
from
e39bd29 to
6be9ca5
Compare
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
Just some minor nits and questions :) But looks nice ✅
| func getWebAppURL() string { | ||
| // allows overriding the URL for testing | ||
| if url := os.Getenv("LOCALSTACK_WEB_APP_URL"); url != "" { | ||
| return url |
There was a problem hiding this comment.
Theoretically we could use it to test against staging or locally started webapp.
I wonder though if we should maybe look into handling these envvars with the config package? I'll refactor it slightly later maybe
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM, but looks like the build is failing now :)
2 participants
This PR adds a device code flow as a fallback option when the browser-based authentication doesn't work.
When running
lstk start, the CLI now supports two authentication paths:User Experience
When running
lstk:If user presses ENTER after confirming in browser:
Mock Server Approach
This PR introduces a platform API client.
The device flow tests use
httptest.NewServerto create a real HTTP server that mimics the platform API.The production code remains unchanged, we just point it to a different URL via
LOCALSTACK_PLATFORM_URL.This allows
TestDeviceFlowSuccessto verify the complete end-to-end flow including container startup with a valid token.