add a new aws client tool#3
Merged
Merged
Conversation
remotesynth
approved these changes
Sep 5, 2025
remotesynth
left a comment
remotesynth
left a comment
Collaborator
There was a problem hiding this comment.
Did some basic testing and it seemed to work correctly
HarshCasper
added a commit
that referenced
this pull request
Jul 4, 2026
* fix: make LocalStack lifecycle CLI-agnostic (support lstk; Docker-API stop) Follow-up to #49 (gap #3). start/stop/restart hardcoded the Python `localstack` binary and the management preflight hard-required it, so an `lstk`-only host (no Python CLI) couldn't start/stop/restart through the MCP even though its LocalStack was running. - stop: stop the already-detected container via the Docker API — provenance- agnostic and CLI-free (works for localstack / lstk / compose / raw `docker run`). - start: detect whichever lifecycle CLI is present (`localstack`, else `lstk`) rather than hardcoding `localstack`; clear error if neither is installed. - restart: Docker-API stop + start (still applies new envVars). - drop `requireLocalStackCli` from the management preflight (status/stop/restart no longer need it; start detects a CLI itself). Snowflake start still requires `localstack` — `--stack snowflake` is localstack-only. Also (gap #6, for the lifecycle spawn): set PYTHONIOENCODING=utf-8 / PYTHONUTF8=1 on the start subprocess so the Python CLI's emoji output doesn't crash under the Windows cp1252 code page. Adds DockerApiClient.stopContainer and detectLifecycleCli with unit tests, plus lifecycle tool-boundary tests. Also restores the management status tests that were dropped from main during the #49 squash merge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * improve the code * fix the snowflake cli timeout * fix the docker test * remove the test file (to be setup later) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: HarshCasper <erbeusgriffincasper@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.