Expand on quote parsing, add aliases, add case insensitive args#137
Open
libraryaddict wants to merge 1 commit into
Open
Expand on quote parsing, add aliases, add case insensitive args#137libraryaddict wants to merge 1 commit into
libraryaddict wants to merge 1 commit into
Conversation
* Allows arguments to be case insensitive (eg, "shouldFlyMonkey" is no longer so case strict) * Allows negation to also be `-` instead of just `!` * Quoted arguments are a bit smarter, with only strings that start with a quote character being treated as a quote, and a quote will consume everything until it reaches an unescaped quote that must end at the end of the life, or with a space after * Adds aliases for a key, with an error message to match it With a string parameter if you pass in arg=\"notquoted\" then it would output the backslashes as well, which could be unwanted? But the simple solution there is to `"\"notquoted\""` or `""notquoted""` which are effectively the same thing. The proper solution would be to make it stricter, but then you run into the user error issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-instead of just!With a string parameter if you pass in arg="notquoted" then it would output the backslashes as well, which could be unwanted? But the simple solution there is to
"\"notquoted\""or""notquoted""which are effectively the same thing.The proper solution would be to make it stricter, but then you run into the user error issue.