[CIR][TargetLowering] Add type support in CIRLowerContext and LowerTypes #2105
+131
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranapratap55
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Contributor
Author
| break; | ||
| } | ||
| if (mlir::isa<VoidType>(T)) { | ||
| Width = 0; |
Member
There was a problem hiding this comment.
Is this true for every target? What OG does about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for additional CIR types in the target lowering enabling the
CallConvLoweringpass to work with vector types, half-precision floats, and other floating-point types.Added type info support for:
FP16Type- half precision float (16-bit)BF16Type- bfloat16FP80Type- x86 extended precision (80-bit)FP128Type- quad precision (128-bit)VoidType- void type (for pointer pointees)VectorType- SIMD vector types