ai/live: terminate streams signaled by heartbeat response#3902
Open
gioelecerati wants to merge 1 commit into
Open
ai/live: terminate streams signaled by heartbeat response#3902gioelecerati wants to merge 1 commit into
gioelecerati wants to merge 1 commit into
Conversation
sendHeartbeat was only inspecting the HTTP status code and discarding the response body on 2xx, so the terminatedStreamIds list from the gateway was silently dropped and affected streams kept heartbeating forever. Parse the body, and for each returned stream id look up the matching LivePipeline and invoke its kickInput func (stored as StopStream on the pipeline at registerControl time). That triggers the existing cleanup chain: segmenter cancel → cleanupControl → orchCancel. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3902 +/- ##
===================================================
- Coverage 32.87450% 32.85752% -0.01698%
===================================================
Files 171 171
Lines 42063 42103 +40
===================================================
+ Hits 13828 13834 +6
- Misses 27194 27225 +31
- Partials 1041 1044 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendHeartbeat was only inspecting the HTTP status code and discarding the response body on 2xx, so the terminatedStreamIds list from the gateway was silently dropped and affected streams kept heartbeating forever.
What does this pull request do? Explain your changes. (required)
Parse the body, and for each returned stream id look up the matching LivePipeline and invoke its kickInput func (stored as StopStream on the pipeline at registerControl time). That triggers the existing cleanup chain: segmenter cancel → cleanupControl → orchCancel.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass