Repository navigation
feat(cmd): ux feedback - #1051
rektdeckard wants to merge 8 commits into
Conversation
… size, add pagination hints
|
Me and claude went through Two things: |
yeah 1000 is safe. https://live-kit.slack.com/archives/C02RXL72MQA/p1792097914902789 |
| // when the recording started (to line the audio up with the transcript), from | ||
| // the signed URL response r the download came from. | ||
| func RecordingSaved(p *util.Printer, r oapi.LivekitPublicapiObservabilityV1RecordingGetURLResponse, s SavedRecording) error { | ||
| p.Statusf("Saved %s of session to [%s] (%s)", RecordingLabel(s.Recording), |
There was a problem hiding this comment.
+1 to what @JackNDwyer said about putting the path on stdout. also while ur in here the session id got dropped so it says "saved chat history of session to [...]", and the recording start time doesnt print anymore either. r gets passed in for it but never used. 0f6680e changed TestRecordingSaved to match the current output so prob worth putting those assertions back too
| next := page.Cursor | ||
| for { | ||
| items, cursor, err := fetch(public.PageOptions{ | ||
| Limit: min(public.MaxPageSize, page.Limit-int32(len(all))), |
There was a problem hiding this comment.
since livekit/public-api-server#82 drops the max for transcript/logs/traces/metrics we can just ask for whatever's left in one go here, like Limit: page.Limit - int32(len(all)), and kill MaxPageSize entirely. default read becomes 1 request instead of limit/1000, and metrics especially bc GetMetrics reads the whole session on every page anyway.
Implement some UX feedback on CLI commands:
--sinceflag (--since 2was an alternative to--start 2026-10-02)lk analytics session transcriptmatch the live transcript output when runninglk agent console,lk agent debugger--jsonoutput of some experimental commands (consistent way of showing pagination, prefer raw response shapes to something made-up)--type=audioforlk analytics session recordingand handles file name collisionscharm.land/bubbleteapackage to fix issue with form output not being cleared from the terminal