Recover from stranded flushnig on end of stream too - #1315
Merged
Conversation
The previous change added recovery from stranded flushing on packet push - so that track can start ingesting packets into pipeline correctly. There is one more case that will benefit from recovery - sending end of stream signal - if packets started flushing but recovery wasn't yet performed (didn't reach the threshold) and track/recording ends - writer will try to send EOS and that call will get the same flow flushing error, so EOS never propagets and we get the same pipeline frozen error. The change here introduces the recovery path for that use case as well. This is the only appsrc related cause of pipeline forzen errors remaining that I can see in logs.
boks1971
approved these changes
Jul 29, 2026
Contributor
|
AV-sync stats summary: view in run #30444401634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change added recovery from stranded flushing on packet push - so that track can start ingesting packets into pipeline correctly. There is one more case that will benefit from the recovery - sending the end of stream signal - if packets started flushing but the recovery wasn't yet performed (didn't reach the threshold) and the track/recording ends - a writer will try to send EOS and that call will get the same flow flushing error, so EOS never propagates and we get the same pipeline frozen error. The change here introduces the recovery path for that use case as well. This is the only appsrc related cause of pipeline frozen errors remaining that I can see in logs.