Repository navigation
Fix verifier reference equality across recorded upcasts - #383
Open
CatarinaGamboa wants to merge 1 commit into
Open
CatarinaGamboa wants to merge 1 commit into
CatarinaGamboa wants to merge 1 commit into
Conversation
rcosta358
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a caught
IOExceptionto anExceptionlocal currently crashes verification with incompatible Z3 sorts. Translate mixed reference equality through an exact recorded supertype view, symmetrically for either operand order.Preserve alias identity across native and inherited reference views with cached, on-demand solver equivalences between their equality propositions. Equality itself remains a single typed equality, so negating it for
!=preserves the same identity semantics. Numeric handling is unchanged; unrelated mixed reference sorts remain outside this fix.Adds passing caught-upcast and inherited Throwable state/alias cases, failing unknown-state and already-initialized-cause cases, and solver regressions covering both equality/inequality operand orders and satisfiable distinct references.
Validation:
ReferenceEqualityTestpasses; both CLI fixtures produce exactly their expected outcomes. The full Java 20 CI suite passed on the final on-demand implementation; an earlier localmvn testpassed 390 tests.Fixes #377.