Disable SELKIES_ENABLE_PLAYER4 when gamepad is disabled - #168
Closed
junkerderprovinz wants to merge 1 commit into
Closed
Disable SELKIES_ENABLE_PLAYER4 when gamepad is disabled#168junkerderprovinz wants to merge 1 commit into
junkerderprovinz wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
junkerderprovinz
force-pushed
the
fix/disable-player4-when-no-gamepad
branch
from
July 13, 2026 23:19
6514925 to
8b239ff
Compare
Contributor
Author
|
Gentle nudge whenever you have a moment: this is a one-line change and shows |
1 task
Contributor
Author
|
For the reviewer: this fixes #167 (SELKIES_ENABLE_PLAYER4 never disabled under NO_GAMEPAD — PLAYER3 was set twice). |
1 task
Contributor
Author
Member
|
These are in the bases now thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When gamepad support is disabled (
NO_GAMEPADset, or themknod /dev/input/js0probe fails), theelsebranch ininit-selkies-config/rundisables the gamepad-related Selkies env vars. It setsSELKIES_ENABLE_PLAYER2andSELKIES_ENABLE_PLAYER3tofalse, then repeatsSELKIES_ENABLE_PLAYER3a second time instead of settingSELKIES_ENABLE_PLAYER4:So
/run/s6/container_environment/SELKIES_ENABLE_PLAYER4is never written and player-4 sharing keeps its default (True) even though no gamepad devices exist. This changes the duplicated line to targetSELKIES_ENABLE_PLAYER4.Benefits of this PR and context:
README.md/readme-vars.ymldocument exactly three sharing-link players —SELKIES_ENABLE_PLAYER2/3/4, all defaulting toTrue— so all three should be turned off together in the no-gamepad branch. closes #167How Has This Been Tested?
Diffed the
elseblock:SELKIES_ENABLE_PLAYER2,PLAYER3andPLAYER4now each appear exactly once. Cross-checked the variable names againstREADME.mdandreadme-vars.yml. LF-only, one-line change. Reviewer runtime check:docker run --rm -e NO_GAMEPAD=1 <image> with-contenv env | grep SELKIES_ENABLE_PLAYERshould now listSELKIES_ENABLE_PLAYER4=falsealongsidePLAYER2/PLAYER3.Source / References:
closes #167