Skip to content

Disable SELKIES_ENABLE_PLAYER4 when gamepad is disabled - #168

Closed
junkerderprovinz wants to merge 1 commit into
linuxserver:masterfrom
junkerderprovinz:fix/disable-player4-when-no-gamepad
Closed

Disable SELKIES_ENABLE_PLAYER4 when gamepad is disabled#168
junkerderprovinz wants to merge 1 commit into
linuxserver:masterfrom
junkerderprovinz:fix/disable-player4-when-no-gamepad

Conversation

@junkerderprovinz

@junkerderprovinz junkerderprovinz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

When gamepad support is disabled (NO_GAMEPAD set, or the mknod /dev/input/js0 probe fails), the else branch in init-selkies-config/run disables the gamepad-related Selkies env vars. It sets SELKIES_ENABLE_PLAYER2 and SELKIES_ENABLE_PLAYER3 to false, then repeats SELKIES_ENABLE_PLAYER3 a second time instead of setting SELKIES_ENABLE_PLAYER4:

printf "false" > /run/s6/container_environment/SELKIES_ENABLE_PLAYER2
printf "false" > /run/s6/container_environment/SELKIES_ENABLE_PLAYER3
printf "false" > /run/s6/container_environment/SELKIES_ENABLE_PLAYER3   # <- should be PLAYER4

So /run/s6/container_environment/SELKIES_ENABLE_PLAYER4 is never written and player-4 sharing keeps its default (True) even though no gamepad devices exist. This changes the duplicated line to target SELKIES_ENABLE_PLAYER4.

Benefits of this PR and context:

README.md / readme-vars.yml document exactly three sharing-link players — SELKIES_ENABLE_PLAYER2/3/4, all defaulting to True — so all three should be turned off together in the no-gamepad branch. closes #167

How Has This Been Tested?

Diffed the else block: SELKIES_ENABLE_PLAYER2, PLAYER3 and PLAYER4 now each appear exactly once. Cross-checked the variable names against README.md and readme-vars.yml. LF-only, one-line change. Reviewer runtime check: docker run --rm -e NO_GAMEPAD=1 <image> with-contenv env | grep SELKIES_ENABLE_PLAYER should now list SELKIES_ENABLE_PLAYER4=false alongside PLAYER2/PLAYER3.

Source / References:

closes #167

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@junkerderprovinz
junkerderprovinz force-pushed the fix/disable-player4-when-no-gamepad branch from 6514925 to 8b239ff Compare July 13, 2026 23:19
@junkerderprovinz

Copy link
Copy Markdown
Contributor Author

Gentle nudge whenever you have a moment: this is a one-line change and shows MERGEABLE. Happy to rebase or adjust if anything is needed. Thanks for maintaining the image!

@junkerderprovinz

Copy link
Copy Markdown
Contributor Author

For the reviewer: this fixes #167 (SELKIES_ENABLE_PLAYER4 never disabled under NO_GAMEPAD — PLAYER3 was set twice).

@junkerderprovinz

Copy link
Copy Markdown
Contributor Author

Thanks @thelamer — same here, feel free to close this alongside #169 once tomorrow's batched base-image build lands with the player fix in it. Glad it's useful.

@thelamer

Copy link
Copy Markdown
Member

These are in the bases now thanks

@thelamer thelamer closed this Jul 17, 2026
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[BUG] SELKIES_ENABLE_PLAYER4 not set when gamepad is disabled

3 participants