Skip to content

tinycarebot@ap0r: Initial upload. - #8911

Closed
ap0r wants to merge 5 commits into
linuxmint:masterfrom
ap0r:master
Closed

tinycarebot@ap0r: Initial upload.#8911
ap0r wants to merge 5 commits into
linuxmint:masterfrom
ap0r:master

Conversation

@ap0r

@ap0r ap0r commented Jul 30, 2026

Copy link
Copy Markdown

Uploaded tinycarebot (the applet that I made, see https://github.com/ap0r/Tinycarebot for detailed info) so that it can be downloaded directly from within Mint.

@github-actions

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_load_contents

tinycarebot@ap0r/files/tinycarebot@ap0r/applet.js:17

let [success, data] = messagesFile.load_contents(null);

Synchronous load_contents() blocks the main loop.
Use load_contents_async() instead.


Automated pattern check.

@ap0r ap0r changed the title Tinycarebot: Initial upload. Tinycarebot@ap0r: Initial upload. Aug 2, 2026
@ap0r ap0r changed the title Tinycarebot@ap0r: Initial upload. tinycarebot@ap0r: Initial upload. Aug 2, 2026
@ap0r ap0r closed this Aug 5, 2026
@ap0r ap0r reopened this Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_load_contents

tinycarebot@ap0r/files/tinycarebot@ap0r/applet.js:17

let [success, data] = messagesFile.load_contents(null);

Synchronous load_contents() blocks the main loop.
Use load_contents_async() instead.


Automated pattern check.

1 similar comment
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_load_contents

tinycarebot@ap0r/files/tinycarebot@ap0r/applet.js:17

let [success, data] = messagesFile.load_contents(null);

Synchronous load_contents() blocks the main loop.
Use load_contents_async() instead.


Automated pattern check.

@claudiux
claudiux marked this pull request as draft August 5, 2026 21:04
Modified and tested
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 2 potential issue(s):

⚠️ WARNING

⚠️ lang_bind

tinycarebot@ap0r/files/tinycarebot@ap0r/applet.js:25

messagesFile.load_contents_async(null, Lang.bind(this, function(file, result) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

tinycarebot@ap0r/files/tinycarebot@ap0r/applet.js:55

this.timer = Mainloop.timeout_add_seconds(300, Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.


Automated pattern check.

Fixed the fix. Now let's see what else pops up.
@ap0r
ap0r marked this pull request as ready for review August 5, 2026 21:33
@ap0r

ap0r commented Aug 5, 2026

Copy link
Copy Markdown
Author

Let's hope this is good now, making it work with load_async() was surprisingly difficult. Probably skill issue on my end.

File already present, so possibly a case sensitivity issue.
@ap0r

ap0r commented Aug 6, 2026

Copy link
Copy Markdown
Author

Please, whoever reads this, provide some clear feedback as to why this is not accepted, if any issues remain please explain them, I am new to contributing to open source and the experience has been superbly frustrating so far.

@ap0r ap0r closed this Aug 7, 2026
@ap0r ap0r reopened this Aug 7, 2026
@ap0r ap0r closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant