Skip to content

azan@fahri.nurul.id: Updated settings, new features, fixes and other minor tweaks. - #8864

Open
M-Hassand wants to merge 2 commits into
linuxmint:masterfrom
M-Hassand:update-azan
Open

azan@fahri.nurul.id: Updated settings, new features, fixes and other minor tweaks.#8864
M-Hassand wants to merge 2 commits into
linuxmint:masterfrom
M-Hassand:update-azan

Conversation

@M-Hassand

@M-Hassand M-Hassand commented Jul 10, 2026

Copy link
Copy Markdown

Changelog

  • Updated the settings, settings-schema.json, to follow modern Cinnamon style (pages and sections instead of headers and separators) and added tooltips to various settings.
  • Added the ability to turn off reminders at prayer time.
  • Added the ability to manually increase or decrease times up to 60 minutes (closes Applet Feature Request #6974).
  • The settings button now works. (closes Applet Bug: applet setting not displaying #6316).
  • Fixed a typo in weekdays ("Khamis" instead of "Khams").
  • Changed the settings button label from "Settings" to "Azan Settings" to better match other applets (e.g. Network Settings, Sound Settings, Notification Settings).
  • Updated README.md.
  • Updated the version in metadata.json.
  • Updated screenshot.png to reflect the look on Cinnamon 6.

Original Author

Fahri Nurul Hidayat (@fahrinh).

@github-actions

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 1 potential issue(s):

ℹ️ INFO

ℹ️ shell_string_spawn

azan@fahri.nurul.id/files/azan@fahri.nurul.id/applet.js:160

Util.spawnCommandLine("xlet-settings applet " + this._metadata.uuid);

Prefer argument vector spawn functions over shell command strings.
This is especially important when arguments include untrusted input (user data,
filenames, settings values, etc.) as shell strings are vulnerable to injection.
Static command strings are generally fine, but argv is always safer.
Use Util.spawn(["cmd", "arg1", "arg2"]) or Util.trySpawn() instead.


Automated pattern check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applet Feature Request Applet Bug: applet setting not displaying

1 participant