Skip to content

Add 8-day history menu and local caching". - #8827

Open
ACCaceres wants to merge 1 commit into
linuxmint:masterfrom
ACCaceres:patch-1
Open

Add 8-day history menu and local caching".#8827
ACCaceres wants to merge 1 commit into
linuxmint:masterfrom
ACCaceres:patch-1

Conversation

@ACCaceres

Copy link
Copy Markdown
Contributor

Updated the Bing image request path to fetch 8 images instead of 1. Added a history submenu for the last 8 days of wallpapers and improved logging for image downloads.

Updated the Bing image request path to fetch 8 images instead of 1. Added a history submenu for the last 8 days of wallpapers and improved logging for image downloads.
@github-actions

Copy link
Copy Markdown
Contributor

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.


Found 2 potential issue(s):

⚠️ WARNING

⚠️ sync_file_query_exists

bing-wallpaper@starcross.dev/files/bing-wallpaper@starcross.dev/applet.js:95

if (gFile.query_exists(null)) {

query_exists() is a synchronous call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

⚠️ lang_bind

bing-wallpaper@starcross.dev/files/bing-wallpaper@starcross.dev/applet.js:85

menuItem.connect('activate', Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.


Automated pattern check.

@rcalixte

Copy link
Copy Markdown
Member

You opened two pull requests to update the same file. Can you consolidate the changes into a single pull request and tag the author/maintainer on the open one when you are complete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants