Fix linuxdeploy log directory rename#177
Conversation
|
For context, this adjustment is necessary in response to linuxdeploy/linuxdeploy@2b73a21. It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it). |
You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though. At any rate, @dantti please rebase this branch, then we can merge it. |
70e3e97 to
90703c8
Compare
90703c8 to
3d9d609
Compare
3d9d609 to
f5f6ca5
Compare
|
@TheAssassin this is ready to be merged, CI is broken due other stuff (which a few are addressed in another PR) |
|
@TheAssassin ping |
268f4d6 to
14541e8
Compare
|
rebased again |
|
Sorry for the delay, have not had any time to review this before. |
|
Thanks a lot! |
Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.