feat: support move xembed window on treeland#1573
Draft
BLumia wants to merge 1 commit intolinuxdeepin:masterfrom
Draft
feat: support move xembed window on treeland#1573BLumia wants to merge 1 commit intolinuxdeepin:masterfrom
BLumia wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
通过 treeland 提供的 API 移动 xembed 窗口 Log:
BLumia
force-pushed
the
xembed-treeland-move
branch
from
18de6a1 to
d0bfc61
Compare
tsic404
reviewed
Apr 29, 2026
| PluginSurface *pluginSurface = findPluginSurface(plugin_id, item_key); | ||
| if (pluginSurface) { | ||
| dx = pluginSurface->itemPosition().x(); | ||
| dy = pluginSurface->itemPosition().y(); |
Contributor
There was a problem hiding this comment.
这个 itemPosition 是在任务栏上的位置偏移吗？如果托盘是在展开区域的话，这个位置正确吗？
| return false; | ||
| } | ||
|
|
||
| m_ddeShellManager->setXWindowPositionRelative(wid, m_dockWlSurface, dx, dy); |
Contributor
There was a problem hiding this comment.
此处都是基于 dockWlSurface 进行偏移，是否有考虑托盘在展开区域情况呢？
|
TAG Bot New tag: 2.0.39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
通过 treeland 提供的 API 移动 xembed 窗口。