Fix rolegroupmodel memoryleak

debian/control

@@ -15,6 +15,7 @@ Build-Depends:
  libdtk6widget-dev,
  libdtkcommon-dev,
  libgtest-dev,
+ libgmock-dev,
  libicu-dev,
  libqt6svg6,
  libxcb-ewmh-dev,

panels/dock/taskmanager/rolegroupmodel.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -13,6 +13,11 @@ RoleGroupModel::RoleGroupModel(QAbstractItemModel *sourceModel, int role, QObjec
     RoleGroupModel::setSourceModel(sourceModel);
 }
 
+RoleGroupModel::~RoleGroupModel()
+{
+    qDeleteAll(m_map);
+}
+
 void RoleGroupModel::setDeduplicationRole(const int &role)
 {
     if (role != m_roleForDeduplication) {

panels/dock/taskmanager/rolegroupmodel.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -12,6 +12,7 @@ class RoleGroupModel : public QAbstractProxyModel
 
 public:
     explicit RoleGroupModel(QAbstractItemModel *sourceModel, int role, QObject *parent = nullptr);
+    ~RoleGroupModel() override;
     void setSourceModel(QAbstractItemModel *sourceModel) override;
 
     void setDeduplicationRole(const int &role);

panels/notification/common/dataaccessorproxy.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -34,6 +34,9 @@ void DataAccessorProxy::setSource(DataAccessor *source)
     if (!source)
         return;
 
+    if (m_source == source)
+        return;
+
     if (m_source) {
         delete m_source;
     }

tests/panels/CMakeLists.txt

@@ -1,5 +1,6 @@
-# SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+# SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 #
 # SPDX-License-Identifier: CC0-1.0
 
 add_subdirectory(dock)
+add_subdirectory(notification)

tests/panels/dock/taskmanager/combinemodela.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -43,6 +43,12 @@ TestModelA::TestModelA(QObject *parent)
 
 }
 
+TestModelA::~TestModelA()
+{
+    qDeleteAll(m_list);
+    m_list.clear();
+}
+
 QHash<int, QByteArray> TestModelA::roleNames() const
 {
     return {

tests/panels/dock/taskmanager/combinemodela.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -34,6 +34,7 @@ class TestModelA : public QAbstractListModel
     };
     Q_ENUM(Roles)
     TestModelA(QObject *parent = nullptr);
+    ~TestModelA();
     QHash<int, QByteArray> roleNames() const override;
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     QVariant data(const QModelIndex &index, int role) const override;

tests/panels/dock/taskmanager/combinemodelb.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -43,6 +43,12 @@ TestModelB::TestModelB(QObject *parent)
 
 }
 
+TestModelB::~TestModelB()
+{
+    qDeleteAll(m_list);
+    m_list.clear();
+}
+
 QHash<int, QByteArray> TestModelB::roleNames() const
 {
     return {

tests/panels/dock/taskmanager/combinemodelb.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -33,6 +33,7 @@ class TestModelB : public QAbstractListModel
     };
     Q_ENUM(Roles)
     TestModelB(QObject *parent = nullptr);
+    ~TestModelB();
     QHash<int, QByteArray> roleNames() const override;
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     QVariant data(const QModelIndex &index, int role) const override;

tests/panels/dock/taskmanager/rolecombinemodeltests.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -68,7 +68,8 @@ TEST(RoleGroupModel, ModelTest)
         return QModelIndex();
     });
 
-    [[maybe_unused]] auto tester = new QAbstractItemModelTester(&model, QAbstractItemModelTester::FailureReportingMode::Fatal);
+    auto tester = new QAbstractItemModelTester(&model, QAbstractItemModelTester::FailureReportingMode::Fatal);
+    delete tester;
 }
 
 TEST(RoleCombineModel, dataTest) {