Skip to content

test: remove unused files#626

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused
Jun 23, 2026
Merged

test: remove unused files#626
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused

Conversation

@richm

@richm richm commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements

pylintrc is not used in this repo

use ansible-core - much smaller than ansible

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Chores
    • Updated Ansible dependencies to use ansible-core for Python 2.6+
    • Removed Docker and Molecule testing configuration files
    • Removed linting configuration and requirement file documentation
    • Streamlined version-specific dependency specifications

We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements

pylintrc is not used in this repo

use ansible-core - much smaller than ansible

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fcf8ff78-70a9-418e-becb-63438be15de7

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc4779 and e89c76c.

📒 Files selected for processing (7)
  • ansible_pytest_extra_requirements.txt
  • custom_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml
  • molecule_extra_requirements.txt
  • pylintrc
  • pytest_extra_requirements.txt
💤 Files with no reviewable changes (5)
  • pylintrc
  • molecule_extra_requirements.txt
  • custom_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml

📝 Walkthrough

Walkthrough

The PR replaces the ansible package with ansible-core in ansible_pytest_extra_requirements.txt and pytest_extra_requirements.txt, consolidating multi-line Python 2.x conditional pins into a single marker. Several files are fully removed: custom_requirements.txt, molecule_extra_requirements.txt, molecule/default/Dockerfile.j2, molecule/default/molecule.yml, and pylintrc.

Changes

ansible-core migration and file cleanup

Layer / File(s) Summary
Replace ansible with ansible-core in requirements files
ansible_pytest_extra_requirements.txt, pytest_extra_requirements.txt
Both files drop multi-line Python 2.x conditional constraints (idna<2.8, PyYAML<5.1, ansible<2.7) and replace the ansible dependency with a single ansible-core ; python_version > "2.6" line.
Removed configuration and molecule files
custom_requirements.txt, molecule_extra_requirements.txt, molecule/default/Dockerfile.j2, molecule/default/molecule.yml, pylintrc
custom_requirements.txt and molecule_extra_requirements.txt (both containing only SPDX headers and stub comments), the molecule Dockerfile template and scenario configuration (Docker driver, CentOS 7/8 platform definitions, provisioner, test sequence), and the full autogenerated pylintrc are all deleted.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks the required template structure. It should follow the Enhancement/Reason/Result format from the repository template but instead provides informal bullet points without proper section organization. Restructure the description to follow the Enhancement/Reason/Result template format, organizing the removal rationale and outcomes into the specified sections.
Description Format ⚠️ Warning PR description does not follow the required template from .github/pull_request_template.md; missing "Enhancement:"/"Feature:", "Reason:", and "Result:" sections. Rewrite PR description following template: Enhancement: [describe changes], Reason: [explain why needed], Result: [describe outcome/impact].
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'test: remove unused files' follows the Conventional Commits format with a valid 'test' type and clearly describes the main purpose of removing unused files and dependencies from the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.16%. Comparing base (59fd1c6) to head (e89c76c).
⚠️ Report is 146 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (e89c76c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (e89c76c)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   16.54%   10.16%   -6.39%     
==========================================
  Files           2        9       +7     
  Lines         284     2056    +1772     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1847    +1610     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit d2af4d7 into linux-system-roles:main Jun 23, 2026
39 of 40 checks passed
@richm richm deleted the test-remove-unused branch June 23, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant