lib: Gave blkdev and chardev checks platform agnostic names.#3281
lib: Gave blkdev and chardev checks platform agnostic names.#3281bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
|
@igaw This is the change we discussed last week to make checking the handle type platform agnostic and based on the intended use rather than whether it is block device or character device. |
|
Looks good to me. I wonder if we should just extend the help text to something like FWIW, we can even make the example platform specific later. |
bgoing-micron-oss
force-pushed
the
platform-agnostic-ctrl-and-ns-handle-checks
branch
from
4e14e8f to
ed1d289
Compare
On Linux, controller devices are character devices, and namespace devices are block devices. This is not true on platforms like Windows. - Changed platform-specific libnvme_transport_handle_is_chardev and libnvme_transport_handle_is_blkdev to platform-agnostic libnvme_transport_handle_is_ctrl and libnvme_transport_handle_is_ns. This also helps to make the intent of the checks more clear. - Changed error messages to use platform-agnostic controller/namespace wording as well. Signed-off-by: Broc Going <bgoing@micron.com>
bgoing-micron-oss
force-pushed
the
platform-agnostic-ctrl-and-ns-handle-checks
branch
from
ed1d289 to
43f276c
Compare
|
@igaw I've updated the error string as suggested. I left the error strings in nvme.c unchanged because they seemed consistent with the other error strings, but I updated the main help string which shows examples of controller and namespace device names. If you would like further changes, let me know. Thanks. |
|
I've changed the commit messages to present tense to keep it consist with the rest and applied it directly. Thanks! |
2 participants
On Linux, controller devices are character devices, and namespace devices are block devices. This is not true on platforms like Windows.