generate-accessors: fix stale examples and redundant code#3280
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Apr 16, 2026
Merged
generate-accessors: fix stale examples and redundant code#3280igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
The examples in generate-accessors.md were generated with an older
version of the tool:
- excluded members leave no trace; the phantom "no accessors" comment
has been removed
- car struct accessors were missing their KernelDoc comments
- accessors.c used 4-space indentation instead of tabs
- accessors.ld was not shown at all
In generate-accessors.py, collapse the redundant two-branch isdigit()
check in emit_src_setter_chararray() — both branches produced identical
output.
Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a bit of clean up.
The examples in generate-accessors.md were generated with an older version of the tool:
In generate-accessors.py, collapse the redundant two-branch isdigit() check in emit_src_setter_chararray() — both branches produced identical output.