Repository navigation
firehose: match the VIP marker on its common prefix - #332
Closed
HurtCopain wants to merge 1 commit into
Closed
HurtCopain wants to merge 1 commit into
HurtCopain wants to merge 1 commit into
Conversation
The programmer's VIP announcement is matched with strstr() against
#define VIP_PROGRAMMER_MARKER "VIP is enabled, receiving the signed table"
OPlus SM8850 (kaanapali) programmer builds word it differently:
INFO: VIP is enabled, receiving the partition info of size 36864
The match fails, so qdl warns that the programmer did not announce VIP,
silently skips the signed digest table, and the following <configure> is
rejected by the target:
ERROR: VIP img authentication failed with smc_status = 0xfffffffe, rsp_0 = 0x40000b
ERROR: Verifying signature failed with 150994958
Both wordings share the prefix "VIP is enabled"; match on that instead.
Tested on an OPPO CPH2841 (SM8850, kaanapali) with the OEM-signed
DigestsToSign table: VIP now completes and <configure> is ACKed.
Signed-off-by: hurt copain <jacksummers715@gmail.com>
Author
|
Force-pushed to add Signed-off-by (DCO). No code changes. |
Contributor
|
The diff doesn't contain its own fix described in the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The programmer's VIP announcement is matched with strstr() against
OPlus SM8850 (kaanapali) programmer builds word it differently:
The match fails, so qdl warns that the programmer did not announce VIP, silently skips the signed digest table, and the following is rejected by the target:
Both wordings share the prefix "VIP is enabled"; match on that instead.
Tested on an OPPO CPH2841 (SM8850, kaanapali) with the OEM-signed DigestsToSign table: VIP now completes and is ACKed.