Skip to content

fix: DBaaS Advanced config state#13367

Merged
hana-akamai merged 2 commits intolinode:developfrom
hana-akamai:fix-advanced-config-state
Feb 6, 2026
Merged

fix: DBaaS Advanced config state#13367
hana-akamai merged 2 commits intolinode:developfrom
hana-akamai:fix-advanced-config-state

Conversation

@hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Feb 4, 2026

Description 📝

Undo watch refactor to DatabaseAdvancedConfigurationDrawer as it ended up causing a bunch of issues after getting merged. I also added some unit tests since there wasn't any before and Sakshi is looking into extending e2e coverage

No changeset needed since bugs hasn't made it into production yet

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Next release

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have a mysql and postgres Database cluster

Reproduction steps

(How to reproduce the issue, if applicable)

  • On the develop branch, edit an advanced config that has a dropdown, the value resets to the initial value instead of the selected value
  • Switch toggle fields (such as pg_stat_monitor_enable) are not toggling
  • On modifying configs that need a restart (e.g. pg_stat_monitor_enable), Save button isn't updating to "Save and Restart Service"

Verification steps

(How to verify changes)

  • Checkout this PR preview link or checkout this PR
  • Edit an advanced config that has a dropdown, the value should not reset to the initial value
  • Switch toggle fields should be toggling
  • On modifying configs that need a restart, the Save button should update to "Save and Restart Service"
pnpm test DatabaseAdvancedConfigurationDrawer
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hana-akamai hana-akamai self-assigned this Feb 4, 2026
@hana-akamai hana-akamai added Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service labels Feb 4, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing865 Passing11 Skipped37m 41s

Details

Failing Tests
SpecTest
quotas-storage.spec.tsCloud Manager Cypress Tests→Quota workflow tests→Quota storage table » Quotas and quota usages display properly

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts"

@hana-akamai hana-akamai marked this pull request as ready for review February 6, 2026 18:15
Copy link
Contributor

@smans-akamai smans-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified steps for UI behavior and unit tests!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 6, 2026
@hana-akamai hana-akamai merged commit 73cda1e into linode:develop Feb 6, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 6, 2026
@hana-akamai hana-akamai deleted the fix-advanced-config-state branch February 6, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants