Repository navigation
[test] replace curls to linode API with linode CLI and replace fixed sleeps with state checks - #649
Merged
Merged
Conversation
github-actions
Bot
added
the
testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 19 19
Lines 2616 2616
=======================================
Hits 2162 2162
Misses 454 454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AshleyDumaine
force-pushed
the
e2e-cleanup
branch
from
October 26, 2026 14:13
acdc2bf to
8e72006
Compare
…tting rate-limiting or resource errors on the API
AshleyDumaine
force-pushed
the
e2e-cleanup
branch
from
October 26, 2026 18:02
7bb003b to
80e9285
Compare
AshleyDumaine
marked this pull request as ready for review
October 26, 2026 18:42
…assert NB persists
AshleyDumaine
force-pushed
the
e2e-cleanup
branch
2 times, most recently
from
October 26, 2026 19:48
77fc79d to
5e79a42
Compare
komer3
reviewed
Oct 26, 2026
komer3
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our e2e tests call the Linode API with raw curl and wait with fixed sleep calls (which slow down the already slow tests even further). The change swaps those curls to use the linode-cli and replaces the fixed waits with checks of the state the test needs.