Skip to content

[fix] render subnetIDs and vpcIDs as strings in daemonset template - #646

Merged
AshleyDumaine merged 1 commit into
linode:mainfrom
srager13:fix-helm-chart-ids-rendering
Oct 20, 2026
Merged

AshleyDumaine merged 1 commit into
linode:mainfrom
srager13:fix-helm-chart-ids-rendering

Conversation

@srager13

Copy link
Copy Markdown
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Description:

Format numeric VPC, subnet, and backend subnet IDs as base-10 integers before rendering them as quoted CLI arguments. Preserve existing comma-separated string values. Add render regression coverage for top-level IDs, routeController overrides, and CSV strings, and run it in the Helm workflow.

Fixes #645

Testing:

bash hack/test-helm-id-args.sh; helm lint deploy/chart

@github-actions github-actions Bot added the bugfix for any bug fixes in the changelog. label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (6fcdcfa) to head (9ebb1f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          19       19           
  Lines        2616     2616           
=======================================
  Hits         2162     2162           
  Misses        454      454           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine
AshleyDumaine merged commit 706ebcb into linode:main Oct 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm renders numeric VPC and subnet IDs in scientific notation

2 participants