refactor(load-biaser): replace pending with arc strong count#4556
Closed
cratelyn wants to merge 1 commit into
Closed
refactor(load-biaser): replace pending with arc strong count#4556cratelyn wants to merge 1 commit into
cratelyn wants to merge 1 commit into
Conversation
see #4537. this commit explores using `Arc::strong_count` for tracking the number of pending requests. some tests fail as a result of this change, which i haven't fully tracked down. Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/amr-load-biaser-arc-count-instead
branch
from
0a2d115 to
579c2a4
Compare
Member
Author
|
see d16388a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see
#4537.
this commit explores using
Arc::strong_countfor tracking the numberof pending requests.
some tests fail as a result of this change, which i haven't fully
tracked down.