add proxyInit dual-stack conditional#696
Open
panic-kbutton wants to merge 1 commit intolinkerd:mainfrom
Open
Conversation
Signed-off-by: Kevin Button <kevin@thinkingmachines.ai>
panic-kbutton
force-pushed
the
proxy-init-patch
branch
from
0fcfdcf to
bc7c219
Compare
Author
|
@alpeb any more info needed for this change? thanks! |
unleashed
reviewed
Apr 24, 2026
Member
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
Thanks for your submission, @panic-kbutton!
I just noticed a couple improvements we could have (see comments).
Comment on lines
+204
to
+206
| if isIPv6Subnet != options.IPv6 { | ||
| continue | ||
| } |
Member
There was a problem hiding this comment.
Maybe avoid silently dropping non-matched subnets?
Suggested change
| if isIPv6Subnet != options.IPv6 { | |
| continue | |
| } | |
| if isIPv6Subnet != options.IPv6 { | |
| log.Debugf("skipping subnet %s: doesn't match current stack (ipv6=%v)", subnet, options.IPv6) | |
| continue | |
| } |
| } | ||
| }) | ||
|
|
||
| t.Run("It handles IPv4-only subnets with dual-stack enabled", func(t *testing.T) { |
Member
There was a problem hiding this comment.
We're missing the case of IPv6-only subnets with single-stack IPv4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running Linkerd in dual stack mode today, skipSubnets breaks proxyInit with error similar to:
this breaks when passing either ipv4 or ipv6 subnets to skip subnets (or both), where either the iptables-nft or ip6tables-nft command breaks with the wrong subnet. This PR adds a conditional to verify subnet parsing with the right scheme so that on each invocation only the right subnets are parsed