Repository navigation
Conversation
7 of 17 tasks
cbb330
force-pushed
the
chbush/read-bridge-misfit-message-ahv5f
branch
from
November 21, 2026 01:06
aba085d to
bf35dde
Compare
cbb330
changed the base branch from
main
to
chbush/read-bridge-default-binds-ahv5f
November 21, 2026 01:06
cbb330
force-pushed
the
chbush/read-bridge-misfit-message-ahv5f
branch
from
November 21, 2026 01:14
bf35dde to
cdcc266
Compare
cbb330
force-pushed
the
chbush/read-bridge-misfit-message-ahv5f
branch
2 times, most recently
from
November 21, 2026 02:17
b917790 to
aeee99b
Compare
cbb330
force-pushed
the
chbush/read-bridge-misfit-message-ahv5f
branch
3 times, most recently
from
November 21, 2026 02:37
7b495e9 to
ee4ea04
Compare
…not fit
A table can store a column default that does not fit the type its column
had in an older schema version, such as 8000000000 on an int column later
promoted to bigint. Every Java client load of such a table fails, before
and after this change. Only the error message changes.
Before: read-bridge: unusable config for table db.tbl
After: COLUMN_DEFAULT_UNUSABLE: OpenHouse cannot apply the column defaults
declared on db.tbl (TYPE_MISMATCH, column n, field ID 2). The
default does not fit int, the column's type in schema version 0.
The new message names the column, in the form the server uses when it
refuses such a default. Iceberg's own error ("Cannot parse default as a
int value: 8000000000") does not. So before ReadBridge.apply sets a
default on its column in a schema version, it checks the default fits,
with the steps Iceberg's SchemaParser takes for an initial-default. A
default that fits loads as before.
A default that does not fit is thrown as ColumnDefaultDoesNotFitException,
a ReadBridgeException whose message is the new one. OpenHouseTableOperations
catches it before other ReadBridgeExceptions, which keep the old message.
cbb330
force-pushed
the
chbush/read-bridge-misfit-message-ahv5f
branch
from
November 21, 2026 02:48
ee4ea04 to
9209720
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR only changes an error message in the Java client.
A table can store a column default that does not fit the type its column had in an older schema version, such as
8000000000on anintcolumn later promoted tobigint. Every load of such a table fails, before and after this PR. #911 stops the server from accepting such a default. Tables stored before #911 can still have one, and need an operator to fix it.read-bridge: unusable config for table db.tblCOLUMN_DEFAULT_UNUSABLE: OpenHouse cannot apply the column defaults declared on db.tbl (TYPE_MISMATCH, column n, field ID 2). The default does not fit int, the column's type in schema version 0.The new message names the column, in the form the server uses when it refuses such a default (see
SETUP.md).Iceberg's own error,
Cannot parse default as a int value: 8000000000, does not name the column. So beforeReadBridge.applysets a default on its column in a schema version, it checks that the default fits, with the steps Iceberg'sSchemaParsertakes for aninitial-default. A default that fits loads as before.A default that does not fit is thrown as
ColumnDefaultDoesNotFitException, aReadBridgeExceptionwhose message is the new one.OpenHouseTableOperationscatches it before otherReadBridgeExceptions, which keep the old message.Stacked on #911.
Changes
Testing Done
Manually Tested on local docker setup. Please include commands ran, and their output.
Added new tests for the changes made.
Updated existing tests to reflect the changes made.
No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
Some other form of testing like staging or soak time in production. Please explain.
ReadBridgeTest: a default of8000000000on a column promoted frominttobigintfails with the message above.OpenHouseTableOperationsTest: a refresh of a table whoseintcolumnidhas the default8000000000fails withTasks.UnrecoverableExceptionand theCOLUMN_DEFAULT_UNUSABLEmessage fordb.tbl.With JDK 17,
ReadBridgeTest(12) andOpenHouseTableOperationsTest(41) pass on Iceberg 1.2 and 1.5.A throwaway check, not committed, loaded the promoted table through
OpenHouseTableOperations.doRefreshon this PR and on [default values] Follow Iceberg's column-default rules after the opt-in, and require defaults to fit every schema version #911. With the default8000000000, both fail with the same root cause,IllegalArgumentException: Cannot parse default as a int value: 8000000000, and the Before and After messages above. With the default7, both load, with the default in both schema versions.Additional Information