vello_gpu: Remove the WebGL state guard - #1911
Merged
Merged
Conversation
LaurenzV
added this pull request to stack #1912
September 14, 2026 13:29
laurenz-canva
pushed a commit
that referenced
this pull request
Sep 15, 2026
laurenz-canva
force-pushed
the
laurenz/remove_state_guard
branch
from
September 15, 2026 08:18
1b26be3 to
3417c6b
Compare
laurenz-canva
pushed a commit
that referenced
this pull request
Sep 15, 2026
laurenz-canva
force-pushed
the
laurenz/remove_state_guard
branch
from
September 15, 2026 08:58
3417c6b to
45181e4
Compare
LaurenzV
added a commit
that referenced
this pull request
Sep 16, 2026
LaurenzV
force-pushed
the
laurenz/remove_state_guard
branch
from
September 16, 2026 11:11
45181e4 to
3cdefdb
Compare
laurenz-canva
force-pushed
the
laurenz/remove_state_guard
branch
from
September 17, 2026 10:33
3cdefdb to
52c92e4
Compare
grebmeg
self-requested a review
September 17, 2026 23:34
grebmeg
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
WebGlStateGuardcompletely from Vello GPU.WebGlRendereralready documents that we don't make any guarantees about preserving existing WebGL state, so it's better to remove the guard completely. While some research by Codex suggests that querying framebuffer and pixel pack buffer state should not be expensive on mainstream browsers, it's still better to be safe than sorry, especially since the guard isn't necessary anymore.