Conversation
|
Seems like it somehow negatively affects WASM size for vello_cpu? Any idea why? |
|
Hmm, 20% raw size increase but 3.8% increase gzipped; probably added something repetitive that gzip can easily remove. I'll see what I can do to investigate. |
|
Codex bisected the regression to linebender/fearless_simd@ff8ee04 I've reverted that commit, let me re-run the benchmarks |
fine/fill/opaque_long_u8_avx2
time: [13.623 ns 13.624 ns 13.625 ns]
change: [-43.012% -42.974% -42.939%] (p = 0.00 < 0.05)
Performance has improved.This performance improvement stays, the other fill improvements are gone. I'll see what I can do about that. Also, one more regression appeared that I'll need to address. |
|
Fixed pixmap/unpremultiply/opaque benchmark regression. The short AVX2 paths vary in timings between runs, so the earlier 20% improvement was spurious. Results as of 1d34528: fine/fill/opaque_long_u8_avx2 improves by 40%, all other run-by-default benchmarks are neutral. |
demonstrates how linebender/fearless_simd#347 applies to vello_cpu
x86 build times are unchanged, surprisingly.
No performance regressions from this PR. The initial conversion introduced some, but sticking
#[inline(always)]on 3 functions fixed it - that's commit de2e4c1I'm seeing performance improvements for fills: