Skip to content

Send line-bot-sdk-php's version as user agent#852

Merged
Yang-33 merged 7 commits into
masterfrom
user-agent
Jun 26, 2026
Merged

Send line-bot-sdk-php's version as user agent#852
Yang-33 merged 7 commits into
masterfrom
user-agent

Conversation

@Yang-33

@Yang-33 Yang-33 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Currently, the user agent value is hardcoded as LINE-BotSDK-PHP/11, even though the actual SDK version has been 12 for some time.

Since it's easy to forget updating this value like current situation, let's retrieve the SDK version at runtime, as the other bot sdks do.

This usage is explicitly supported and allowed by the Composer API.

@Yang-33 Yang-33 linked an issue Jun 26, 2026 that may be closed by this pull request
@Yang-33 Yang-33 requested a review from a team June 26, 2026 01:33
@Yang-33 Yang-33 added this pull request to the merge queue Jun 26, 2026
Merged via the queue into master with commit 02830c5 Jun 26, 2026
12 checks passed
@Yang-33 Yang-33 deleted the user-agent branch June 26, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send actual version as user agent

2 participants