Add form-param regression tests for ChannelAccessToken and ManageAudience#823
Merged
mokuzon merged 1 commit intoJun 26, 2026
Merged
Conversation
renovate
Bot
force-pushed
the
renovate/openapi-generator-version
branch
from
6d2ab46 to
610fd0b
Compare
renovate
Bot
force-pushed
the
renovate/openapi-generator-version
branch
from
610fd0b to
f9ebe70
Compare
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
2 times, most recently
from
cec5fc7 to
eb1e4bf
Compare
mokuzon
changed the title
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
5 times, most recently
from
ea77e56 to
541b70a
Compare
This was referenced May 28, 2026
This was referenced Jun 2, 2026
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
2 times, most recently
from
6dd83ae to
da7f595
Compare
This was referenced Jun 24, 2026
Yang-33
added a commit
that referenced
this pull request
Jun 24, 2026
1 task
Contributor
|
issues about form param keys are resolved by openapi generator 7.23.0 OpenAPITools/openapi-generator#23347 |
Contributor
|
how about just adding tests in this PR? |
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
from
da7f595 to
653deb6
Compare
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
from
653deb6 to
3d12c83
Compare
mokuzon
changed the title
…anageAudience Cover snake_case form/query keys for the remaining ChannelAccessTokenApi endpoints (issueChannelToken, issueChannelTokenByJWT, revokeChannelToken, revokeChannelTokenByJWT, verifyChannelToken), including their async variants, and add multipart upload form-key tests for ManageAudienceBlobApi, locking in the form param key behavior fixed upstream in openapi-generator 7.23.0. Adopt the Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration trait across the API test classes so that the '->once()' send expectations are actually verified, keeping the test suite consistent.
mokuzon
force-pushed
the
users/mokuson/NO-ISSUE/fix-openapi-7.21-form-params
branch
from
3d12c83 to
6d90538
Compare
Contributor
Author
Thank you. I've made this a PR containing only the tests. |
Yang-33
approved these changes
Jun 26, 2026
Yang-33
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add form-param regression tests:
test/clients/channel-access-token/Api/ChannelAccessTokenApiTest.phpissueChannelTokenissueChannelTokenByJWTrevokeChannelTokenrevokeChannelTokenByJWTverifyChannelTokentest/clients/manage-audience/Api/ManageAudienceBlobApiTest.php(new)createAudienceForUploadingUserIds/addUserIdsToAudienceOriginal description (obsolete: superseded by the upstream fix in openapi-generator 7.23.0)
resolve #810
Summary
api.mustachetemplate to use{{paramName}}(camelCase) as form data keys inFormDataProcessor::prepare(), instead of{{baseName}}(snake_case)grantType=client_credentialsinstead ofgrant_type=client_credentials), breaking all form-based endpointsapi.mustacheoverride with a single-line fix:'{{baseName}}'instead of'{{paramName}}'Test plan
python generate-code.pywith 7.21.0 locally and check diff of auto generated codesissueStatelessChannelTokentests