adding factory methods for PathPattern#807
Closed
noodlze wants to merge 1 commit into
Closed
Conversation
Codecov ReportBase: 65.71% // Head: 65.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
============================================
- Coverage 65.71% 65.56% -0.16%
Complexity 3289 3289
============================================
Files 350 351 +1
Lines 13731 13766 +35
Branches 1488 1492 +4
============================================
+ Hits 9024 9026 +2
- Misses 3863 3896 +33
Partials 844 844
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Author
|
Replaced by #809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft of my implementation for the issue #659.
I still need to add tests.
I added the following methods:
PathPattern#endsWithPathPattern.underPathPattern#ofacceptingPathPattern... pathPatternsI added PathPatternBuilder class to support combining existing patterns: