Fix/cache children prevent nondeterministic adapter bugs#10
Merged
linde9821 merged 3 commits intoMay 20, 2026
Merged
Conversation
…ic adapter bugs
- Add childrenOf cache populated once during initNodes; algorithm no
longer calls adapter.children() after initialization
- Document identity contract on TreeAdapter (deterministic children,
consistent parent-child, unique membership)
- Add test proving layout works with adapters returning new list instances
linde9821
deleted the
fix/cache-children-prevent-nondeterministic-adapter-bugs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Walker layout algorithm called
adapter.children()multiple times per node during traversal.If an adapter returned a new list instance on each call (e.g.
toList()), the precomputedindexAmongSiblingswould reference stale objects, causing silent layout corruption orindex-out-of-bounds crashes in
leftSibling.initNodesand use it exclusively throughout thealgorithm, making it structurally immune to non-deterministic adapters.
TreeAdapterso users understand the expectations.also add new compile targets