ioutilx: replace cygpath with pure Go path conversion#4994
Open
varsha-0007 wants to merge 3 commits into
Open
Conversation
Signed-off-by: varsha <varsha.narvi.07@gmail.com> fix: fix import grouping for gci linter Signed-off-by: varsha <varsha.narvi.07@gmail.com> fix: fix import grouping and trailing whitespace Signed-off-by: varsha <varsha.narvi.07@gmail.com> fix: fix gci import grouping Signed-off-by: varsha <varsha.narvi.07@gmail.com>
Signed-off-by: varsha <varsha.narvi.07@gmail.com>
varsha-0007
force-pushed
the
remove-cygpath
branch
from
e8fcb8c to
e027481
Compare
Signed-off-by: varsha <varsha.narvi.07@gmail.com> ioutilx: replace cygpath with pure Go path conversion Signed-off-by: varsha <varsha.narvi.07@gmail.com>
varsha-0007
force-pushed
the
remove-cygpath
branch
from
e027481 to
c7ef3f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dependency on cygpath.exe by replacing the external
tool call in WindowsSubsystemPath with pure Go path conversion
using filepath and strings packages.
This is part of the cygpath.exe removal work tracked in #4907.
paths (e.g. /c/Users/foo) natively in Go
Signed-off-by: Varsha varsha.narvi.07@gmail.com