Skip to content

Fix Solr OKP default URL missing /solr path#1431

Open
are-ces wants to merge 1 commit intolightspeed-core:mainfrom
are-ces:fix-solr-default-url
Open

Fix Solr OKP default URL missing /solr path#1431
are-ces wants to merge 1 commit intolightspeed-core:mainfrom
are-ces:fix-solr-default-url

Conversation

@are-ces
Copy link
Copy Markdown
Contributor

@are-ces are-ces commented Mar 30, 2026

Description

The default Solr base URL (RH_SERVER_OKP_DEFAULT_URL) was missing the /solr path prefix, causing 404 Not Found errors when the OKP provider connected to Solr collections (e.g. http://localhost:8081/portal-rag/select instead of http://localhost:8081/solr/portal-rag/select).

Type of change

  • Bug fix

Tools used to create PR

  • Assisted-by: Claude Code (Claude Opus 4.6)
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

Tested using solr as knowledge base

Summary by CodeRabbit

  • Chores
    • Updated the default Solr endpoint configuration to append the /solr path segment to the base URL. This ensures the correct endpoint is used when no custom configuration is provided.

The default Solr base URL was missing the /solr path prefix,
causing 404 errors when connecting to Solr collections.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9e2757d7-1734-44b5-b57b-751937af4435

📥 Commits

Reviewing files that changed from the base of the PR and between ee0bcf9 and 967c86b.

📒 Files selected for processing (1)
  • src/constants.py
 _____________________________________________________________
< 🥕 I brought carrots. You brought corner cases. Let's party. >
 -------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@are-ces are-ces requested review from Jared-Sprague and tisnik March 30, 2026 12:21
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@tisnik
Copy link
Copy Markdown
Contributor

tisnik commented Mar 30, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants