Fix Solr OKP default URL missing /solr path#1431
Open
are-ces wants to merge 1 commit intolightspeed-core:mainfrom
Open
Fix Solr OKP default URL missing /solr path#1431are-ces wants to merge 1 commit intolightspeed-core:mainfrom
are-ces wants to merge 1 commit intolightspeed-core:mainfrom
Conversation
The default Solr base URL was missing the /solr path prefix, causing 404 errors when connecting to Solr collections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default Solr base URL (
RH_SERVER_OKP_DEFAULT_URL) was missing the/solrpath prefix, causing404 Not Founderrors when the OKP provider connected to Solr collections (e.g.http://localhost:8081/portal-rag/selectinstead ofhttp://localhost:8081/solr/portal-rag/select).Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
Tested using solr as knowledge base
Summary by CodeRabbit
/solrpath segment to the base URL. This ensures the correct endpoint is used when no custom configuration is provided.