Skip to content

lndclient: expose list payments options#281

Merged
starius merged 1 commit into
lightninglabs:masterfrom
starius:list-payments-options
Jun 17, 2026
Merged

lndclient: expose list payments options#281
starius merged 1 commit into
lightninglabs:masterfrom
starius:list-payments-options

Conversation

@starius

@starius starius commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@starius starius requested a review from ziggie1984 June 11, 2026 21:36
@ziggie1984

Copy link
Copy Markdown
Contributor

hmm for some reason this branch still references the LND 20.1 in the go.mod which does not have the omit_hop option, curious why it still compiles

@starius starius force-pushed the list-payments-options branch from 6d2118d to 67478a1 Compare June 12, 2026 18:40
@starius

starius commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Great catch! I pushed a wrong branch. I force-pushed, please take another look.

curious why it still compiles

CI runs PR jobs on GitHub's synthetic merge commit, not directly on the pushed PR head commit, that it why it was green.

@starius starius requested a review from ellemouton June 13, 2026 04:44

@ellemouton ellemouton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@starius starius force-pushed the list-payments-options branch from 67478a1 to 4122b8c Compare June 17, 2026 18:49
@starius

starius commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Rebased

@starius starius merged commit 7f92a9d into lightninglabs:master Jun 17, 2026
1 check passed
@starius starius deleted the list-payments-options branch June 17, 2026 19:11
@starius

starius commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Tagged as v0.21.0-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants