Expose server version on GetNodeInfo - #294
Merged
benthecarman merged 1 commit intoSep 22, 2026
Merged
benthecarman merged 1 commit into
benthecarman merged 1 commit into
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
requested changes
Sep 22, 2026
GetNodeInfo now returns the same `<cargo version> (<git commit>)` string that `ldk-server --version` already prints, so a remote client can see which server build it is talking to. AI-assisted: implemented with goose.
vincenzopalazzo
force-pushed
the
feat/server-version-get-node-info
branch
from
September 22, 2026 03:23
5a90071 to
1660551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetNodeInfonow returnsversion, the same<cargo version> (<git commit>)stringldk-server --versionalready prints.version = 16). Older clients ignore it. Empty only when talking to a server built before this field.AI-assisted: implemented with goose.
Test plan
ldk-server --versionstill prints0.1.0 (<hash>)cargo test -p ldk-server-grpc --libcargo test --manifest-path e2e-tests/Cargo.toml --test e2e test_cli_get_node_infoassertsversionis present and matches the--versionform