-
Notifications
You must be signed in to change notification settings - Fork 23
Add Claude.md #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Claude.md #112
Conversation
|
I've assigned @joostjager as a reviewer! |
joostjager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see claude change behavior with this file present?
| - Hard tabs, max width 100 chars | ||
| - Imports grouped: std, external crates, local crates | ||
|
|
||
| ## Development Rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could mention "Always ensure that tests pass and lints are fixed before committing". Also, maybe, "run cargo +nightly fmt before committing if nightly channel Rust is locally installed already"? Or do you feel such things rather belong in the local/personal CLAUDE.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not put the nightly fmt in here. If we merge a PR without it, we don't want someone else's PR formatting other unrelated code
|
Apparently this file is loaded into the context at the start of every session. Recommendation is too keep it short and only have it contain non-obvious things. |
Used /init in claude code to make initial structure than added some notes myself.
7ac7495 to
54f6dd2
Compare
|
Simplified claude.md a lot and made a contributing.md that has more details |
Used
/initin claude code to make initial structure than added some notes myself.