fix(solana): normalize RPC transaction handling - #445
Open
zerone-jang wants to merge 1 commit into
Open
Conversation
5 tasks
🦋 Changeset detectedLatest commit: 58e0b43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRetriesas a JSON number so strict Solana RPC servers acceptsendTransactiongetEpochInfo().blockHeightContext
@solana/kittypesmaxRetriesasbigint, which serializes to\"0\". Solana RPC servers expect a JSON number and reject the request with-32602 Invalid params.We also observed proxied RPC endpoints intermittently returning the slot for single-request
getBlockHeightcalls. Since slots exceedlastValidBlockHeight, this prematurely terminates the confirmation loop.getEpochInfo().blockHeightremained consistent across the same endpoints.These changes were validated with two confirmed Solana swaps through the existing RPC path.
Test plan
pnpm --filter @lifi/sdk-provider-solana test:unit(58 passed)pnpm --filter @lifi/sdk-provider-solana check:typespnpm --filter @lifi/sdk-provider-solana buildpnpm check