fix(deploy): allow intent facets to deploy against codeless settler refs

[gvladika]

Which Linear task belongs to this PR?

Fixes EXSC-748

Why did I implement it this way?

The intent settlers (InputSettlerEscrowLIFI / OutputSettlerSimple) are reserved, deterministically-deployed vanity addresses — identical on every chain. We deploy LiFiIntentEscrowFacetV2 and ReceiverOIF on a chain before the settler is deployed there, so the immutable ref legitimately points at an address that has no code yet (e.g. jovay/megaeth after the 2026-08-06 switchover). DeployReceiverOIF read the output settler through the default _getConfigContractAddress, which runs LibAsset.isContract and reverted on a codeless ref, blocking (re)deployment on those chains.

This reuses the existing 4-arg _getConfigContractAddress overload with allowNonContractAddress=true — the same pattern already used for tempo's dummy wrappedNative in DeployAcrossFacetV4 — scoped only to the settler fields. allowZeroAddress stays false and the Executor read stays checked, so a zero address or a missing real dependency is still caught; only the intentional codeless-settler case is allowed through. The facet script previously read the input settler with a raw stdJson.readAddress (no zero/code checks at all); it now uses the same checked reader, keeping the codeless allowance while adding the zero-address guard it was missing.

No automated test is added: this repo does not unit-test Foundry deploy scripts (the tempo precedent has none either), and getConstructorArgs is internal and env/config-dependent. Functional validation is the actual (re)deploy against a chain whose settler ref is codeless.

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

Changes

Settler address configuration

Layer / File(s)	Summary
LiFi Intent Escrow settler lookup script/deploy/facets/DeployLiFiIntentEscrowFacetV2.s.sol	getConstructorArgs uses _getConfigContractAddress for the settler address. Zero addresses remain invalid, while non-contract addresses are allowed.
ReceiverOIF settler lookup script/deploy/facets/DeployReceiverOIF.s.sol	getConstructorArgs passes the OIFOutputSettlerSimple key directly and allows non-contract addresses while rejecting zero addresses.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• lifinance/contracts#2136: Updates deployment argument handling for ReceiverOIF and LiFiIntentEscrowFacetV2.
• lifinance/contracts#2164: Updates LiFiIntentEscrowFacetV2 settler-address handling.
• lifinance/contracts#2183: Applies non-contract settler-address handling to both deployment scripts.

Suggested labels: AuditNotRequired

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the deployment fix for codeless settler references.
Description check	✅ Passed	The description explains the issue, implementation, validation approach, task, and checklist status; reviewer-only checks remain appropriately unchecked.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/exsc-748-allow-redeploying-intent-facets-against-codeless-reserved

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}