chore(deploy): add LayerSwapFacet v1.0.0 on robinhood (EXSC-718) - #2146
chore(deploy): add LayerSwapFacet v1.0.0 on robinhood (EXSC-718)#21460xDEnYO wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
WalkthroughRobinhood configuration and deployment records register LayerSwap, add the LayerSwapFacet at version 1.0.0, configure ReceiverOIF and OutputValidator addresses, and remove obsolete target-state network entries. ChangesRobinhood LayerSwap integration
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ration (EXSC-718) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployments/robinhood.diamond.json`:
- Around line 83-86: Remove the LayerSwapFacet registration for
0x88545564793A470B511CC3E7e225a459bA29D291 from the production diamond snapshot,
leaving it only in the pending deployment target state until governance proposal
nonce 23 executes. Resync the snapshot after the Safe/timelock cut is confirmed
on-chain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e0c8e831-a370-469c-9a11-355ca09ae382
📒 Files selected for processing (4)
config/layerswap.jsondeployments/robinhood.diamond.jsondeployments/robinhood.jsonscript/deploy/_targetState.json
🔍 QA Review — EXSC-718 — PR #2146Ticket: EXSC-718 — Deploy LayerSwapFacet v1.0.0 to Robinhood + Safe proposal
Post-Approval Commit Reviewed
AnalysisThis is a pure merge-from-main commit that brings the latest Files changed in the merge commit:
EXSC-718 deployment integrity check: ✅
✅ Verdict: Pass (Post-Approval Re-Review)The post-approval commit is a routine QA re-review by lifi-qa-agent[bot] — Run #27 · 2026-07-30 |
![lifi-qa-agent[bot]](https://avatars.githubusercontent.com/in/3411599?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ QA approved. LayerSwapFacet v1.0.0 deployment on Robinhood is correctly configured: depository address consistent with all other chains, targetState updated, governance execution confirmed. (lifi-qa-agent Run #26)
Co-authored-by: Cursor <cursoragent@cursor.com>
6fc05c0
There was a problem hiding this comment.
✅ QA approved (Run #27, post-approval re-review). Merge-from-main sync commit brings only network deprecations and CVE patch from main. LayerSwapFacet deployment files unchanged. (lifi-qa-agent[bot])
3 participants
Which Linear task belongs to this PR?
Fixes EXSC-718
Ref EXP-622
Why did I implement it this way?
Production deploy of LayerSwapFacet v1.0.0 to robinhood (new network for this facet): added the LayerSwap depository config entry, registered the facet in target state, and recorded the CREATE3 address. The diamondCut is a pending timelock-wrapped Safe proposal (nonce 23); production
robinhood.diamond.jsonupdates only when the cut executes.0x88545564793A470B511CC3E7e225a459bA29D291Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)
Made with Cursor