Fix unsigned integer underflow in mp3dec_ex_read_frame leading to heap buffer overflow#148
Open
izumi-hyun wants to merge 1 commit into
Open
Fix unsigned integer underflow in mp3dec_ex_read_frame leading to heap buffer overflow#148izumi-hyun wants to merge 1 commit into
izumi-hyun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an unsigned integer underflow condition in
mp3dec_ex_read_framewithinminimp3_ex.h.During analysis of a malformed MP3 file, I observed a state where:
The remaining buffer size is calculated as:
Because no validation is performed before the subtraction, this results in an unsigned integer underflow and produces an unexpectedly large
buf_sizevalue.The underflow condition was observed together with a reproducible AddressSanitizer-reported heap out-of-bounds read during frame decoding.
Root Cause
If
dec->offset > end_offset, the subtraction underflows.Proposed Fix
This prevents the underflow condition before the buffer size calculation.
Impact
This fix prevents malformed input from triggering the underflow condition and avoids passing an invalid buffer range into the decoding path.