Clean up TestServer test library#87
Merged
Merged
Conversation
dispatch() was called with ($c, $r->method, $r->uri, $r), but method and uri are plain accessors on the request object. Pass only ($c, $r) and let each dispatch() implementation derive method/uri where needed. This also drops $method from TestServer::Reflect::dispatch, which unpacked it but never used it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
======================================
Coverage 8.57% 8.57%
======================================
Files 1 1
Lines 338 338
Branches 86 86
======================================
Hits 29 29
Misses 304 304
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent cleanups to the
t/lib/TestServer*test library. Both are test-only and behavior-preserving.Remove unused var in test lib
TestServer::perl_cmddeclaredmy @libs = $self->lib_dirs;and never used it — the loop just below calls$self->lib_dirsdirectly.Simplify
dispatch()interface to($c, $r)dispatch()was called asdispatch($c, $r->method, $r->uri, $r), but$methodand$uriare plain accessors on the request object$r. Pass only($c, $r)and let eachdispatch()implementation derivemethod/uriwhere it needs them. This also drops$methodfromTestServer::Reflect::dispatch, which unpacked it but never used it.🤖 Generated with Claude Code