hidapi: do not enumerate XInput devices owned by a kernel driver via libusb on macOS#15841
Merged
Merged
Conversation
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With commit 18fc4d9 now XInput devices on macOS are enumerated by libusb in hidapi. Since devices enumerated by libusb are not enumerated by the platform backend:
SDL/src/hidapi/SDL_hidapi.c
Lines 1440 to 1445 in da8aa39
When a device is enumerated by libusb but it cannot be opened (usually due to
libusb_claim_interfacefailure), it doesn't fallback to the platform backend. This is ok forGCControllerdevices but it is a problem for devices which work with the hidapi platform backend. XInput controllers working with 360Controller driver are examples.This PR adds checking if a device is already owned by KEXT by
libusb_kernel_driver_activefunction when enumerating devices.