debian.dockerfile :: Update Debian base image and modify build process - #149
Open
konvlachos wants to merge 2 commits into
Open
debian.dockerfile :: Update Debian base image and modify build process#149konvlachos wants to merge 2 commits into
konvlachos wants to merge 2 commits into
Conversation
Test Build : We have build the docker manually on a rocky 9 vm, using the following cmd docker build --no-cache --build-arg VERSION=2.5.0 -f debian.dockerfile -t icecast:2.5.0-rc1 .
Author
|
Could you please review the current pr, |
paddatrapper
left a comment
paddatrapper
left a comment
Contributor
There was a problem hiding this comment.
Sorry this has taken so long, but here is a review of the changes
| # --------------------------------------------------------- | ||
| COPY --from=builder /build/output / | ||
|
|
||
| # ✅ REQUIRED: libigloo runtime library |
Contributor
There was a problem hiding this comment.
This isn't a helpful comment, please remove
| ENTRYPOINT ["docker-entrypoint"] | ||
|
|
||
| USER $USER | ||
| ENTRYPOINT ["docker-entrypoint"] |
Contributor
There was a problem hiding this comment.
Why are you moving this?
| ADD icecast-$VERSION.tar.gz . | ||
| RUN if test ! -d icecast-$VERSION; then mv icecast-* icecast-$VERSION; fi | ||
|
|
||
| RUN if [ ! -d icecast-$VERSION ]; then \ |
Contributor
There was a problem hiding this comment.
Why are you changing this from test?
| # --------------------------------------------------------- | ||
| WORKDIR /tmp | ||
|
|
||
| RUN curl -fsSL https://downloads.xiph.org/releases/igloo/libigloo-0.9.5.tar.gz \ |
Contributor
There was a problem hiding this comment.
libigloo 0.95 is available from Debian backports. I would prefer using that instead of building our own version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Build:
We have manually built the Docker image on a Rocky Linux 9 VM using the following command:
docker build
--no-cache
--build-arg VERSION=2.5.0
-f debian.dockerfile
-t icecast:2.5.0-rc1 .