Skip to content

fix(ci): avoid rate limits on GitHub API by supplying auth token - #3199

Merged
mxinden merged 1 commit into
masterfrom
fix/install-protoc-via-apt
Dec 7, 2022
Merged

fix(ci): avoid rate limits on GitHub API by supplying auth token#3199
mxinden merged 1 commit into
masterfrom
fix/install-protoc-via-apt

Conversation

@thomaseizinger

@thomaseizinger thomaseizinger commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Description

This follows the recommendation in the Usage section of the action: https://github.com/arduino/setup-protoc#usage
We won't need it once #3024 is landed but the failing CIs are annoying enough to warrant a temporary fix.

Example of a failing CI run: https://github.com/libp2p/rust-libp2p/actions/runs/3630150537/jobs/6123169342

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
thomaseizinger force-pushed the fix/install-protoc-via-apt branch from 0a3cf32 to 7233132 Compare December 6, 2022 23:22
@thomaseizinger thomaseizinger changed the title feat(ci): install protoc via apt fix(ci): avoid rate limits on GitHub API by supplying auth token Dec 6, 2022
@thomaseizinger
thomaseizinger marked this pull request as ready for review December 6, 2022 23:24
@thomaseizinger
thomaseizinger requested a review from jxs December 6, 2022 23:25

@mxinden mxinden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden

mxinden commented Dec 7, 2022

Copy link
Copy Markdown
Member

Testground failure is due to a rename:

failed to load composition file: failed to process composition template: open ping/_compositions/go-rust-interop-latest.toml: no such file or directory

libp2p/test-plans#70

See #2647 (comment) for libp2p-relay and libp2p-dcutr failures.

@mxinden
mxinden merged commit 4da6508 into master Dec 7, 2022
@mxinden

mxinden commented Dec 7, 2022

Copy link
Copy Markdown
Member

Not sure how successful this was. #3191 is now rate limited with an API key.

@thomaseizinger

Copy link
Copy Markdown
Contributor Author

Not sure how successful this was. #3191 is now rate limited with an API key.

Wow, so we replaced one error with another haha

@chunningham chunningham mentioned this pull request Feb 2, 2023
12 tasks
@thomaseizinger
thomaseizinger deleted the fix/install-protoc-via-apt branch February 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants