Narrow no_std_fs_operations exemptions with Whitaker module-path suppressions (#462)

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
       # not shadow .cargo/config.toml and strip -Zpolonius=next; tools such as
       # cargo-llvm-cov append their own flags to this value.
       RUSTFLAGS: -D warnings -Zpolonius=next
-      WHITAKER_INSTALLER_VERSION: '0.2.6'
+      WHITAKER_INSTALLER_VERSION: '0.2.7'
       # Single source of truth for the cargo-nextest pin. `make test` runs the
       # non-doctest suite through nextest, so the job installs it up front.
       NEXTEST_VERSION: '0.9.133'

Cargo.toml

@@ -180,7 +180,10 @@ rustix = { version = "1.0.8", features = ["fs"] }
 
 [workspace]
 # `test_support` is a path dependency that Cargo would otherwise auto-include as a
-# member. It is excluded here to keep its gate coverage unchanged in this focused
-# change; folding it into the workspace is tracked separately as it requires
-# clearing its own lint backlog.
+# member. It stays excluded so its gate coverage is decided deliberately rather
+# than inherited; folding it into the workspace is tracked separately. Because
+# the exclusion also puts the crate out of reach of workspace-root cargo
+# invocations, `make lint-whitaker` runs the Whitaker suite a second time
+# against `test_support/dylint.toml`, and `make test-nextest` and `make doctest`
+# each run a second time against `$(TEST_SUPPORT_MANIFEST)`.
 exclude = ["test_support"]

Makefile

@@ -66,6 +66,9 @@ RUSTDOC_FLAGS ?= --cfg docsrs -D warnings
 VERUS_FLAGS ?=
 VERUS_INSTALL_FLAGS ?=
 WHITAKER ?= whitaker
+# `test_support` is excluded from the root workspace, so root-level cargo
+# invocations cannot reach it; the test and lint recipes target it explicitly.
+TEST_SUPPORT_MANIFEST ?= test_support/Cargo.toml
 
 export PATH := $(HOME)/.cargo/bin:$(HOME)/.local/bin:$(HOME)/.bun/bin:$(PATH)
 
@@ -81,9 +84,13 @@ test: test-nextest doctest ## Run every Rust test with warnings treated as error
 
 test-nextest: ## Run all non-doctest Rust tests through cargo-nextest
 	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) nextest run --all-targets --all-features $(NEXTEST_BUILD_JOBS)
+	# `test_support` is excluded from the root workspace, so the run above cannot
+	# reach its own tests. Run them separately, as lint-whitaker does.
+	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) nextest run --all-targets --all-features --manifest-path "$(TEST_SUPPORT_MANIFEST)" $(NEXTEST_BUILD_JOBS)
 
 doctest: ## Run doctests, which cargo-nextest cannot execute
 	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) test --doc --all-features $(BUILD_JOBS)
+	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) test --doc --all-features --manifest-path "$(TEST_SUPPORT_MANIFEST)" $(BUILD_JOBS)
 
 test-workflow-contracts: ## Validate the mutation-testing caller contract
 	uv run --with 'pytest>=8' --with 'pyyaml>=6' pytest tests/workflow_contracts -q
@@ -98,9 +105,15 @@ lint: lint-clippy lint-whitaker ## Run Clippy and the Whitaker Dylint suite with
 lint-clippy: ## Run rustdoc and Clippy with warnings denied
 	RUSTDOCFLAGS="$(RUSTDOC_FLAGS)" RUSTFLAGS="$${RUSTFLAGS-} $(POLONIUS_FLAGS)" $(CARGO) doc --no-deps
 	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) clippy $(CLIPPY_FLAGS)
+	# `test_support` is excluded from the root workspace, so the run above cannot
+	# reach it. Lint it separately, as lint-whitaker does.
+	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(CARGO) clippy --manifest-path "$(TEST_SUPPORT_MANIFEST)" $(CLIPPY_FLAGS)
 
 lint-whitaker: ## Run the Whitaker Dylint suite with warnings denied
 	RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(WHITAKER) --all -- --all-targets --all-features
+	# `test_support` is excluded from the root workspace, so the run above cannot
+	# reach it. Lint it separately against its own dylint.toml.
+	cd test_support && RUSTFLAGS="$${RUSTFLAGS:+$$RUSTFLAGS }-D warnings $(POLONIUS_FLAGS)" $(WHITAKER) --all -- --all-targets --all-features
 
 fmt: ## Format Rust and Markdown sources
 	$(CARGO) fmt --all
@@ -183,6 +196,9 @@ dev-build: dev-fast-check ## Build the debug binary with Cranelift and mold
 
 dev-test: dev-fast-check ## Run the nextest pass with Cranelift and mold
 	RUSTUP_TOOLCHAIN=$(DEV_FAST_TOOLCHAIN) $(CARGO) --config "$$DEV_FAST_CONFIG" nextest run --all-targets --all-features $(NEXTEST_BUILD_JOBS)
+	# Mirrors test-nextest: `test_support` is excluded from the root workspace,
+	# so the run above cannot reach its tests.
+	RUSTUP_TOOLCHAIN=$(DEV_FAST_TOOLCHAIN) $(CARGO) --config "$$DEV_FAST_CONFIG" nextest run --all-targets --all-features --manifest-path "$(TEST_SUPPORT_MANIFEST)" $(NEXTEST_BUILD_JOBS)
 
 bench-build: dev-fast-check ## Time clean and incremental debug builds for both paths
 	@CARGO="$(CARGO)" scripts/bench-build.sh