Skip to content

Align Dependabot coverage and add the dev-fast build fragment - #476

Draft
leynos wants to merge 5 commits into
mainfrom
parabellum-wave-1
Draft

Align Dependabot coverage and add the dev-fast build fragment#476
leynos wants to merge 5 commits into
mainfrom
parabellum-wave-1

Conversation

@leynos

@leynos leynos commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

This branch applies Wave 1 of the Rust estate baseline remediation
(Operation Parabellum, phase 2). It aligns
.github/dependabot.yml
with the canonical Dependabot reference: one update stanza per package
ecosystem the repository uses (cargo, rust-toolchain, github-actions), each stanza labelled
dependencies plus its channel label, and GitHub Actions updates batched
into a single pull request via a wildcard group. It also adds the opt-in dev-fast build
fragment with dev-build and dev-test Make targets, signposted in
AGENTS.md.

Review walkthrough

Validation

  • Audited the amended tree with the Concordat rule packages
    dependabot-baseline and rust-dev-fast-baseline: dependabot-baseline compliant, rust-dev-fast-baseline compliant.

Notes

  • The canonical labels (including the Dependabot channel labels this
    configuration references) were created on the repository ahead of this
    pull request, so no stanza names a missing label.
  • The dev-fast fragment is strictly opt-in local tooling: it is only
    applied when passed explicitly with --config, so continuous
    integration, release, coverage, and verification builds are untouched.
    The targets need a nightly toolchain and, on Linux, a mold binary on
    the PATH; repositories still pinned to stable gain the wiring now and
    the capability when Wave 2 moves the pin to nightly.

Summary by Sourcery

Align Dependabot configuration with Rust tooling coverage and introduce an opt-in fast debug build workflow for local development.

New Features:

  • Add opt-in dev-fast Make targets dev-build and dev-test that use a dedicated Cargo config fragment for faster local debug builds.
  • Add a nightly-only Cargo configuration fragment under tools/dev-fast/config.toml to enable Cranelift and mold for development builds.

Enhancements:

  • Document the fast development build workflow and its constraints in AGENTS.md, including tooling requirements and isolation from release and CI builds.

Build:

  • Extend Dependabot configuration to track rust-toolchain updates with weekly scheduling and appropriate labels.

Bring `.github/dependabot.yml` to the estate baseline: one update
stanza per package ecosystem the repository uses, each labelled
`dependencies` plus its channel label, with GitHub Actions updates
batched into a single pull request via a wildcard group.

Add the opt-in dev-fast build fragment at
`tools/dev-fast/config.toml` (Cranelift codegen for the dev profile
and the mold linker on Linux) with `dev-build` and `dev-test` Make
targets that pass it explicitly via `--config`, and signpost the
workflow in `AGENTS.md`. Release, coverage, and verification builds
are unaffected: the fragment is never auto-discovered.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cdae5d35-8503-4aca-a107-e984f608e1c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR aligns Dependabot configuration with the canonical Rust baseline and introduces an opt‑in “dev-fast” Cargo config fragment wired into new Make targets and documented in AGENTS.md, without affecting CI or release builds.

Sequence diagram for opt-in dev-fast build and test targets

sequenceDiagram
  actor Developer
  participant Makefile
  participant Cargo
  participant DevFastConfig as tools_dev_fast_config_toml

  Developer->>Makefile: make dev-build
  Makefile->>Cargo: cargo --config DEV_FAST_CONFIG build
  Cargo->>DevFastConfig: read config.toml
  DevFastConfig-->>Cargo: apply profile.dev cranelift and linux mold
  Cargo-->>Developer: debug binaries built

  Developer->>Makefile: make dev-test
  Makefile->>Cargo: cargo --config DEV_FAST_CONFIG test
  Cargo->>DevFastConfig: read config.toml
  DevFastConfig-->>Cargo: apply profile.dev cranelift and linux mold
  Cargo-->>Developer: tests executed with dev-fast config
Loading

File-Level Changes

Change Details Files
Introduce opt-in accelerated development build and test targets wired to a separate Cargo config fragment.
  • Add DEV_FAST_CONFIG variable defaulting to tools/dev-fast/config.toml.
  • Define dev-build and dev-test phony targets invoking cargo with the explicit --config override.
  • Ensure accelerated settings are isolated from existing release and Postgres-targeted build rules.
Makefile
Document the dev-fast workflow and its constraints for local development use only.
  • Add a “Fast development builds” section describing make dev-build and make dev-test usage.
  • Explain nightly toolchain and mold-on-PATH requirements and why the fragment must not be copied into .cargo/config.toml.
  • Clarify that CI, release, coverage, and verification builds are unaffected by the dev-fast configuration.
AGENTS.md
Expand Dependabot coverage to Rust toolchain updates following the canonical labeling scheme.
  • Add a rust-toolchain package-ecosystem entry scoped to the repository root.
  • Apply dependencies and rust-toolchain labels to the new stanza.
  • Schedule weekly updates for rust-toolchain dependencies in line with baseline rules.
.github/dependabot.yml
Add the canonical dev-fast Cargo configuration fragment for Cranelift and mold-based debug builds.
  • Enable the unstable codegen-backend feature in the Cargo config fragment.
  • Configure the dev profile to use the Cranelift backend for faster compilation.
  • Add Linux-only rustflags to use the mold linker via -fuse-ld=mold, leaving other platforms unchanged.
  • Include guidance comments about keeping the fragment out of .cargo/config.toml and restating any repository-wide rustflags in the target table.
tools/dev-fast/config.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

codescene-access[bot]

This comment was marked as outdated.

codescene-access[bot]

This comment was marked as outdated.

The dev-fast rollout writes "mold" (the linker) into AGENTS.md and
the Makefile, and the en-GB-oxendict spelling gate reads it as a
misspelling of "mould", failing CI. Accept the word via the estate's
correction-to-itself pattern in `typos.local.toml`, and mirror it in
the generated dictionary so local runs agree with the regenerated
configuration.
@leynos

leynos commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

The spelling gate failed on this branch because the appended dev-fast text names the mold linker, which the en-GB-oxendict dictionary read as a misspelling of “mould”. The follow-up commit accepts the word via the estate's correction-to-itself pattern in typos.local.toml (mirrored in the generated dictionary); the AGENTS.md and Makefile hunks are untouched, so the companion parabellum-wave-2-3 branches still merge cleanly where they exist.

codescene-access[bot]

This comment was marked as outdated.

codescene-access[bot]

This comment was marked as outdated.

A blanket `mold = "mold"` correction disables detection of genuine
"mould" misspellings everywhere in the repository. Replace it with
pattern-scoped exemptions covering only the linker contexts the
dev-fast rollout introduced (`-fuse-ld=mold`, "mold linker",
"Cranelift + mold", "Cranelift and mold", and backticked `mold`),
and mirror them in the generated dictionary. Text such as "the bread
had mold growing on it" is flagged again.
codescene-access[bot]

This comment was marked as outdated.

Estate review flagged two defects in the fragment's deployed
comments: a stale "copy this fragment" instruction that reads as
nonsense once the file is in place, and a mis-statement of Cargo's
rustflags semantics (Cargo joins the entries of every matching
`[target.*]` table; only the joined result takes precedence over
`[build].rustflags` rather than merging). Both are corrected in the
canonical source; take its bytes verbatim. No configuration key
changes.
codescene-access[bot]

This comment was marked as outdated.

codescene-access[bot]

This comment was marked as outdated.

codescene-access[bot]

This comment was marked as outdated.

The recent spelling-configuration commits edited the committed
`typos.toml` by hand; the pinned typos-config-builder orders entries
canonically, so the drift check rejects the hand-inserted ordering.
Regenerate the file with the repository's own pinned builder. The
diff is ordering only: no pattern is added or removed, and the
scoped mold exemptions behave identically.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No quality gates enabled for this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant